This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: missing qna recognizers when publishing#4559
Merged
boydc2014 merged 5 commits intomicrosoft:mainfrom Oct 28, 2020
Merged
Conversation
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
previously approved these changes
Oct 28, 2020
boydc2014
approved these changes
Oct 28, 2020
Contributor
|
Taking this to fix the qna bot broken in master |
Merged
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: missing qna recognizers when publishing * add unit test * fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In PR #4351 lost the qna recognizers generate logic, The runtime will throw error when use the qna.
This is a quick fix for main branch. In PR #4549 also fixed the issue, and move all this logic to client. But it maybe can not be merged immediately.
Task Item
refs #4549
#minor
Screenshots